Remove Net452 from API project #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Jul 20, 2021
Codecov Report
@@ Coverage Diff @@
## main #2164 +/- ##
==========================================
- Coverage 85.17% 85.08% -0.09%
==========================================
Files 186 186
Lines 6096 6095 -1
==========================================
- Hits 5192 5186 -6
- Misses 904 909 +5
|
|
Ping back from #2138. |
cijothomas
commented
Jul 20, 2021
| @@ -0,0 +1,4 @@ | |||
| override OpenTelemetry.Context.AsyncLocalRuntimeContextSlot<T>.Get() -> T | |||
There was a problem hiding this comment.
these were part of netstandard2.0 already and now it'll be part of net461 as well. since we haven't shipped this in net461, putting this under unshipped.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2138
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes